netdev - Re: [PATCH net-next] sfc: add extra RX drop counters for nodesc_trunc and noskb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Jul 2014 13:21:43 +0100
From:	Edward Cree <ecree@...arflare.com>
To:	Varka Bhadram <varkabhadram@...il.com>
CC:	<netdev@...r.kernel.org>, Dave Miller <davem@...emloft.net>,
	<linux-net-drivers@...arflare.com>
Subject: Re: [PATCH net-next] sfc: add extra RX drop counters for nodesc_trunc
 and noskb_drop

On 15/07/14 12:10, Varka Bhadram wrote:
> On 07/15/2014 04:28 PM, Edward Cree wrote:
>> Added a counter rx_noskb_drop for failure to allocate an skb.
>> Summed the per-channel rx_nodesc_trunc counters earlier so that they can
>>   be included in rx_dropped.
>>
>>
> check patch errors on this patch...  :-)
>
"Macros with complex values should be enclosed in parenthesis" is a
false positive - the macro is for a structure initialiser.
The long lines are both justifiable and only slightly over 80 columns.
So checkpatch is just being fascist as usual ;)

-Edward
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html