netdev - Re: [PATCH] r8169: Enable RX_MULTI_EN for RTL_GIGA_MAC_VER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Jul 2014 15:25:17 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	romieu@...zoreil.com
Cc:	hayeswang@...ltek.com, michel@...nzer.net, nic_swsd@...ltek.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] r8169: Enable RX_MULTI_EN for RTL_GIGA_MAC_VER_40

From: Francois Romieu <romieu@...zoreil.com>
Date: Tue, 15 Jul 2014 23:54:12 +0200

> Hayes Wang <hayeswang@...ltek.com> :
>>  Michel D?nzer [mailto:michel@...nzer.net] 
> [...]
>> > Without this, the ethernet port on my ASUS A88X Pro mainboard stops
>> > working sometimes, with messages like these in dmesg:
>> > 
>> > AMD-Vi: Event logged [IO_PAGE_FAULT device=05:00.0 
>> > domain=0x001e address=0x0000000000003000 flags=0x0050]
>> 
>> I search the information about your issue. It seems to be
>> relative to the IOMMU. I don't sure if your patch is the root
>> cause or a workaround.
> 
> Btw, a few extra identifiers in rtl_init_rxcfg may improve consistency:
> 
>            missing             |          included
> -------------------------------+-------------------------------
> RTL_GIGA_MAC_VER_36 (8168f)    | RTL_GIGA_MAC_VER_35 (8168f)
> RTL_GIGA_MAC_VER_38 (RTL8411)  | RTL_GIGA_MAC_VER_44 (RTL8411)
> RTL_GIGA_MAC_VER_39 (RTL8106e) | RTL_GIGA_MAC_VER_43 (RTL8106e)
> RTL_GIGA_MAC_VER_37 (RTL8402)  |

Michel please take Francois's feedback here into consideration and also
provide a more detailed commit message so other people reading the commit
can understand your reasoning for making this change, not just what the
result might be for making it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html