netdev - Re: [PATCH v4] bfin_mac: convert bfin Ethernet driver to NAPI framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 16 Jul 2014 17:46:13 +0800
From:	Sonic Zhang <sonic.adi@...il.com>
To:	Varka Bhadram <varkabhadram@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	adi-buildroot-devel@...ts.sourceforge.net,
	Sonic Zhang <sonic.zhang@...log.com>
Subject: Re: [PATCH v4] bfin_mac: convert bfin Ethernet driver to NAPI framework

Hi Varka,

On Tue, Jul 15, 2014 at 4:54 PM, Varka Bhadram <varkabhadram@...il.com> wrote:
> On 07/15/2014 02:13 PM, Sonic Zhang wrote:
>>
>> From: Sonic Zhang <sonic.zhang@...log.com>
>>
>> Ethernet RX DMA buffers are polled in NAPI work queue other than received
>> directly in DMA RX interrupt handler.
>>
>> Signed-off-by: Sonic Zhang <sonic.zhang@...log.com>
>>
>> ---
>> v2-changes:
>> - avoid test NAPI_STATE_NPSVC bit in net device driver
>>
>> v3-changes:
>> - use tabs while indenting the code
>>
>> v4-changes:
>> - unconditionally compete the NAPI poll and re-enable the MAC_RX IRQ
>>
>> Signed-off-by: Sonic Zhang <sonic.zhang@...log.com>
>> ---
>>   drivers/net/ethernet/adi/bfin_mac.c | 79
>> +++++++++++++++++++++++--------------
>>   drivers/net/ethernet/adi/bfin_mac.h |  1 +
>>   2 files changed, 50 insertions(+), 30 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/adi/bfin_mac.c
>> b/drivers/net/ethernet/adi/bfin_mac.c
>> index 7ae74d4..b838e81 100644
>> --- a/drivers/net/ethernet/adi/bfin_mac.c
>> +++ b/drivers/net/ethernet/adi/bfin_mac.c
>> @@ -1218,11 +1218,13 @@ out:
>>   #define RX_ERROR_MASK (RX_LONG | RX_ALIGN | RX_CRC | RX_LEN | \
>>         RX_FRAG | RX_ADDR | RX_DMAO | RX_PHY | RX_LATE | RX_RANGE)
>>   -static void bfin_mac_rx(struct net_device *dev)
>> +static void bfin_mac_rx(struct napi_struct *napi, int budget)
>>   {
>> +       struct bfin_mac_local *lp = container_of(napi,
>> +                               struct bfin_mac_local, napi);
>
>
> should match open parenthesis
>
>
> struct bfin_mac_local *lp = container_of(napi,
>                                          struct bfin_mac_local,
>                                          napi);
>

OK.

Thanks,

Sonic
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html