netdev - Re: [PATCH v2 net-next 0/2] net: print net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 Jul 2014 17:25:23 +0200
From:	Tom Gundersen <teg@...m.no>
To:	David Laight <David.Laight@...lab.com>
Cc:	Veaceslav Falico <vfalico@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Jason Baron <jbaron@...mai.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Vlad Yasevich <vyasevic@...hat.com>,
	stephen hemminger <stephen@...workplumber.org>,
	Jerry Chu <hkchu@...gle.com>,
	Ben Hutchings <bhutchings@...arflare.com>
Subject: Re: [PATCH v2 net-next 0/2] net: print net_device name/state more often

On Thu, Jul 17, 2014 at 4:48 PM, David Laight <David.Laight@...lab.com> wrote:
> From: Veaceslav Falico
>> Currently we use net_device->name only if it's the NETREG_REGISTERED
>> reg_state, otherwise we return "(unregistered device)".
>>
>> However, we always populate net_device->name on creation, so it's always
>> available to us for use. The only caveat is that we might have a name like
>> "eth%d", in which case we cannot use it as it might change in the future.
>
> While you've got this code out on the operating table what about:
> 1) Tracing the renames into the kernel message buffer.

udev will log to dmesg what renames it does. I agree it would make
more sense to do this from the kernel though, as there are other ways
to rename interfaces than through udev.

Cheers,

Tom

> 2) Including the original name in some of the kernel traces.
>
> I've been trying to diagnose some issues on a system that renames
> its interfaces, and it can get tricky working out which interface
> messages refer to.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html