netdev - Re: [PATCH net-next] Update setapp/getapp prototypes in dcbnl_rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 16 Jul 2014 22:23:03 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	anish@...lsio.com
Cc:	netdev@...r.kernel.org, leedom@...lsio.com,
	dan.carpenter@...cle.com
Subject: Re: [PATCH net-next] Update setapp/getapp prototypes in
 dcbnl_rtnl_ops to return int instead of u8

From: Anish Bhatt <anish@...lsio.com>
Date: Wed, 16 Jul 2014 21:39:34 -0700

> @@ -472,6 +472,8 @@ static int dcbnl_getapp(struct net_device *netdev, struct nlmsghdr *nlh,
>  
>  	if (netdev->dcbnl_ops->getapp) {
>  		up = netdev->dcbnl_ops->getapp(netdev, idtype, id);
> +		if (up < 0)
> +			return up;
>  	} else {
>  		struct dcb_app app = {
>  					.selector = idtype,

'up' is u8 so can never be less than zero.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html