netdev - Re: [PATCH net-next v8 5/6] openvswitch: Sample action without side effects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Jul 2014 14:47:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	pshelar@...ira.com
Cc:	netdev@...r.kernel.org, horms@...ge.net.au, jesse@...ira.com
Subject: Re: [PATCH net-next v8 5/6] openvswitch: Sample action without
 side effects

From: Pravin B Shelar <pshelar@...ira.com>
Date: Tue, 22 Jul 2014 11:35:16 -0700

> * As sample() provides a cloned skb in the unlikely case where there are
>   nested actions other than a single userspace action it is no longer
>   necessary to clone the skb in do_execute_actions() when executing a
>   recirculation action just because the keep_skb parameter is set:

This commit log message talks about recirculation, which has been removed
from this series.

And in fact, I think, for my suggested implementation of recirculation
by just returning and re-running the stack, this whole skb clone issue
either goes away or needs to happen in a different place.

If you recirculate by just returning and re-processing the packet at
the top-level entry point into openvswitch, then that's where you
would clone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html