netdev - Re: [PATCH net-next 3/6] net: bcmgenet: re-align multiple lines correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 22 Jul 2014 21:41:30 -0700
From:	Joe Perches <joe@...ches.com>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net-next 3/6] net: bcmgenet: re-align multiple lines
 correctly

On Tue, 2014-07-22 at 10:55 -0700, Florian Fainelli wrote:
> checkpatch.pl flagged a lot of "CHECK: Alignment should match open
> parenthesis" checks, fix all of them to make the driver neater.

trivial notes

> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
[]
> @@ -670,7 +668,7 @@ static void bcmgenet_update_mib_counters(struct bcmgenet_priv *priv)
>  			if (s->type != BCMGENET_STAT_MIB_RX)
>  				offset = BCMGENET_STAT_OFFSET;
>  			val = bcmgenet_umac_readl(priv, UMAC_MIB_START +
> -								j + offset);
> +						  j + offset);

Maybe better as:

			val = bcmgenet_umac_readl(priv,
						  UMAC_MIB_START + j + offset);

> @@ -1318,7 +1315,7 @@ static unsigned int bcmgenet_desc_rx(struct bcmgenet_priv *priv,
>  
>  		if (unlikely(!(dma_flag & DMA_EOP) || !(dma_flag & DMA_SOP))) {
>  			netif_err(priv, rx_status, dev,
> -					"Droping fragmented packet!\n");
> +				  "Droping fragmented packet!\n");

dropping


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html