netdev - Re: [net-next 11/12] e1000e: Fix EEE in S5 w/ Runtime PM enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 30 Jul 2014 00:11:23 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	"Ertman, David M" <david.m.ertman@...el.com>
Cc:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"nhorman@...hat.com" <nhorman@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	"Wysocki, Rafael J" <rafael.j.wysocki@...el.com>
Subject: Re: [net-next 11/12] e1000e: Fix EEE in S5 w/ Runtime PM enabled

Ertman, David M <david.m.ertman@...el.com> :
[...]

Thanks for the explanation.

[...]
> According to Documentation/power/runtime_pm.txt and
> Documentation/power/pci.txt, the idle call-back is the correct place to
> put the check for applicability, and initiation, of a runtime suspend
> event. The duplication of effort between watchdog and runtime_idle is
> something that I need to explore. There are flow issues involved that will
> take some unraveling to fully evaluate.

I agree (almost: s/the correct place/a correct place/).

Rafael's e4fbce740f078bbc925ba5c86648d9c883968479 illustrated the shrinking
idle callback. It nicely trimmed some complexity between runtime PM and the
relevant driver. It may be of use.

--
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html