lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 01 Aug 2014 11:47:28 +0100 From: Patrick McHardy <kaber@...sh.net> To: Thomas Graf <tgraf@...g.ch> CC: davem@...emloft.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, paulmck@...ux.vnet.ibm.com, josh@...htriplett.org, challa@...ronetworks.com, walpole@...pdx.edu, dev@...nvswitch.org, tklauser@...tanz.ch, netfilter-devel@...r.kernel.org Subject: Re: [PATCH net-next 3/3] nftables: Convert nft_hash to use generic rhashtable On 1. August 2014 11:39:01 GMT+01:00, Thomas Graf <tgraf@...g.ch> wrote: >On 08/01/14 at 11:17am, Patrick McHardy wrote: >> On 1. August 2014 09:52:00 GMT+01:00, Thomas Graf <tgraf@...g.ch> >wrote: >> >If the set size is known in advance, the table is sized accordingly, >> >otherwise the table size will default to 64. This is a slight change >> >in behaviour as previously the default was 4 which eventually >required >> >many expansion iterations. >> >> That's assuming a sufficient number of entries will be added. I think >there >> will be many cases in nftables where the number will be lower. Since >> expansion is not very expansive this number was chosen very >deliberately >> and I'd prefer to keep it. >> >> Other than that: >> >> Acked-by: Patrick McHardy <kaber@...sh.net> > >OK, I will change the nft_hash default size back to 4. Thanks. >I think the expansion is more expensive than it looks though as we >are potentially calling synchronize_rcu() multiple times while >holding a mutex to protect from concurrent mutations. True. On average it should only be a single grace period though IIRC. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists