| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 03 Aug 2014 09:52:58 +0200 From: jflf-kernel@....com To: David Miller <davem@...emloft.net> CC: nic_swsd@...ltek.com, netdev@...r.kernel.org Subject: Re: [PATCH] r8152: add missing Makefile rule On 03/08/14 05:41 AM, David Miller wrote: > From: jflf-kernel@....com > Date: Sat, 02 Aug 2014 01:26:40 +0200 > >> Is seems that this issue has existed ever since the driver was >> added back in 3.10. In Linus' git tree the drivers/net/Makefile was >> last modified before the inclusion of the driver, so I don't know >> if it's ever been possible to build it. > > It gets built, as long as at least one other USB networking driver has > been selected. > > Most people (distributions, developers, maintainers) select all > drivers or some large subset thereof, so would never actually run into > this problem. > > You'd have to specifically have a configuration that enabled r8152 and > no other USB networking driver, in order to trigger this. > > Anyways, I'll apply this, thanks. Very true, thank you for pointing it out. If you haven't done so yet, the patch description could be changed to something like: When it is the only USB net driver selected, the r8152 driver doesn't get built because of a missing rule in drivers/net/Makefile. This change adds the rule and lets the driver build. Thank you! JF -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists