lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 6 Aug 2014 01:00:59 +0100 From: Wei Liu <wei.liu2@...rix.com> To: David Miller <davem@...emloft.net> CC: <zoltan.kiss@...rix.com>, <wei.liu2@...rix.com>, <Ian.Campbell@...rix.com>, <david.vrabel@...rix.com>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <xen-devel@...ts.xenproject.org> Subject: Re: [PATCH net-next 0/2] xen-netback: Changes around carrier handling On Tue, Aug 05, 2014 at 04:07:48PM -0700, David Miller wrote: > From: Zoltan Kiss <zoltan.kiss@...rix.com> > Date: Mon, 4 Aug 2014 16:20:56 +0100 > > > This series starts using carrier off as a way to purge packets when the guest is > > not able (or willing) to receive them. It is a much faster way to get rid of > > packets waiting for an overwhelmed guest. > > The first patch changes current netback code where it relies currently on > > netif_carrier_ok. > > The second turns off the carrier if the guest times out on a queue, and only > > turn it on again if that queue (or queues) resurrects. > > > > Signed-off-by: Zoltan Kiss <zoltan.kiss@...rix.com> > > Signed-off-by: David Vrabel <david.vrabel@...rix.com> > > Applied, but I have some reservations: > Wow, this is fast. I appreciate your speed, but there's still outstanding issues in the series. Apart from some comments on maintainability, the biggest problem is that there's a bug in second patch that needs to be fixed; or I need to be proved wrong. We need to set aside some more time to get those questions answered. I don't think this series is suitable to go in as is. DaveM, could you please advise how to deal with this situation? Wei. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists