netdev - Re: [PATCH net-next v4 5/6] net-timestamp: TCP timestamping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 06 Aug 2014 14:32:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	willemb@...gle.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org,
	richardcochran@...il.com
Subject: Re: [PATCH net-next v4 5/6] net-timestamp: TCP timestamping

From: Willem de Bruijn <willemb@...gle.com>
Date: Wed, 6 Aug 2014 15:20:39 -0400

> On Wed, Aug 6, 2014 at 10:37 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
>> but also that we're going to send multiple reports back to error
>> queue.
> 
> I see. The optimization patch to queue timestamps without payload will
> mitigate that somewhat. I dropped that from the initial patchset, but
> will fix it up for net-next. It may also be possible to squash
> multiple timestamped packets on the errqueue together when they all
> have the same payload, resulting in a single (possibly no-payload)
> packet with repeating cmsgs IP_RECVERR and SCM_TIMESTAMPING. That
> would give O(1) overhead regardless of number of retransmits.

We could attach a singly linked list of small sequence number cookies
to the SKB when it gets queued up.

Upon an ACK, we need only look at the entries at the front of the list
until we see one past the cumulative ACK.

There's a little bit of work to do when SKBs are coalesced or chopped
up, but in return the timestamp indications the user gets will be very
accurate.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html