lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 Aug 2014 01:28:19 +0530 From: Himangi Saraogi <himangi774@...il.com> To: "David S. Miller" <davem@...emloft.net>, Olof Johansson <olof@...om.net>, Daniel Mack <zonque@...il.com>, Dan Carpenter <dan.carpenter@...cle.com>, Felipe Balbi <balbi@...com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Cc: Julia Lawall <julia.lawall@...6.fr> Subject: [PATCH] drivers: net: davinci_cpdma: drop devm_kfree of devm_kzalloc'd data devm_kfree should not have to be explicitly used. The Coccinelle semantic patch that fixes this problem is as follows: // <smpl> @@ expression x,d; @@ x = devm_kzalloc(...) ... ?-devm_kfree(d,x); // </smpl> Signed-off-by: Himangi Saraogi <himangi774@...il.com> Acked-by: Julia Lawall <julia.lawall@...6.fr> --- drivers/net/ethernet/ti/davinci_cpdma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c index 4a000f6..af673f5 100644 --- a/drivers/net/ethernet/ti/davinci_cpdma.c +++ b/drivers/net/ethernet/ti/davinci_cpdma.c @@ -512,7 +512,6 @@ struct cpdma_chan *cpdma_chan_create(struct cpdma_ctlr *ctlr, int chan_num, spin_lock_irqsave(&ctlr->lock, flags); if (ctlr->channels[chan_num]) { spin_unlock_irqrestore(&ctlr->lock, flags); - devm_kfree(ctlr->dev, chan); return ERR_PTR(-EBUSY); } -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists