lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 12 Aug 2014 17:16:28 +0200 From: Geert Uytterhoeven <geert@...ux-m68k.org> To: Paul Gortmaker <paul.gortmaker@...driver.com> Cc: Michael Schmitz <schmitzmic@...il.com>, "Linux/m68k" <linux-m68k@...r.kernel.org>, Debian m68k <debian-68k@...ts.debian.org>, "David S. Miller" <davem@...emloft.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Michael Schmitz <schmitz@...ian.org> Subject: Re: [PATCH] m68k/atari: EtherNEC - ethernet support (ne),> Hi Paul, On Tue, Aug 12, 2014 at 4:55 PM, Paul Gortmaker <paul.gortmaker@...driver.com> wrote: >> @@ -169,6 +169,8 @@ bad_clone_list[] __initdata = { >> #elif defined(CONFIG_PLAT_OAKS32R) || \ >> defined(CONFIG_MACH_TX49XX) >> # define DCR_VAL 0x48 /* 8-bit mode */ >> +#elif defined(CONFIG_ATARI) /* 8-bit mode on Atari, normal on Q40 */ >> +# define DCR_VAL (MACH_IS_ATARI ? 0x48 : 0x49) > > This doesn't make sense. Is not MACH_IS_ATARI set when CONFIG_ATARI > is set? And even if it isn't then just set 48 for MACH_IS_ATARI and m68k kernels can be multi-platform, so we need the MACH_IS_ATARI() runtime check. > let the default of 49 below take the ATARI=y and IS_ATARI=n case, > without the need for the ?: operator at all. On top of that, why > aren't you using the ATARI_ETHERNEC option here for your 48 trigger, > instead of the much higher arch/mach level triggers at all? CONFIG_ATARI_ETHERNEC could be used instead of CONFIG_ATARI, but as ne.c is used on Atari with Ethernec only, it doesn't matter much. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists