netdev - Re: [PATCH] m68k/atari: EtherNEC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 Aug 2014 09:15:47 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Michael Schmitz <schmitzmic@...il.com>
Cc:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	"Linux/m68k" <linux-m68k@...r.kernel.org>,
	debian m68k <debian-68k@...ts.debian.org>,
	"David S. Miller" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] m68k/atari: EtherNEC - ethernet support (ne),>

Hi Michael,

On Tue, Aug 12, 2014 at 11:40 PM, Michael Schmitz <schmitzmic@...il.com> wrote:
> Would you be OK if I expanded the comment like this?
>
> /* ne.c is used on m68k Atari and Q40 computers - the Atari ROM-port
> adapter is 8-bit, Q40 uses ISA */

DaveM already applied it to his tree, and sent a pull request to Linus.

> This would limit the runtime test to the case where it is actually
> needed (untested):
>
> #elif defined(CONFIG_ATARI) && defined(CONFIG_Q40)
> /* multiplatform m68k kernel - the Atari ROM-port adapter is 8-bit,
> Q40 uses ISA */
> #  define DCR_VAL (MACH_IS_ATARI ? 0x48 : 0x49)
> #elif defined(CONFIG_ATARI) /* no Q40 support - 8-bit mode on Atari ROM port */
> #  define DCR_VAL 0x48
> #else
> #  define DCR_VAL 0x49
> #endif

MACH_IS_ATARI already evaluates to a constant on single-platform
kernels, so this is optimized at compile time.
Hence there's not really a need for this.

> Are there any other m68k platforms that use the ne.c driver, Geert?
> apne, hydra and zorro8390 all have their own separate drivers - any
> others?

Not that I'm aware of. Only Q40 has CONFIG_NE2000 in defconfig.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html