lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Aug 2014 17:51:28 +0400 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Sébastien Barré <sebastien.barre@...ouvain.be>, David Miller <davem@...emloft.net> CC: netdev@...r.kernel.org, Gregory Detal <gregory.detal@...ouvain.be> Subject: Re: [PATCH] ipv4: Restore accept_local behaviour in fib_validate_source() Hello. On 08/14/2014 04:45 PM, Sébastien Barré wrote: > Commit 7a9bc9b introduced a short-circuit to avoid calling Please also specify that commit's summary line in parens. > fib_validate_source when not needed. That change took rp_filter > into account, but not accept_local. This resulted in a change > of behaviour: with rp_filter and accept_local off, incoming > packets with a local address in the source field should be > dropped. > Here is how to reproduce the change pre/post 7a9bc9b commit: > -configure the same IPv4 address on hosts A and B. > -try to send an arp request from B to A. > -The arp request will be dropped before commit 7a9bc9b, s/arp/ARP/? > but accepted and answered after that commit. > This adds a check for ACCEPT_LOCAL, to maintain full > fib validation in case it is 0. > Signed-off-by: Sébastien Barré <sebastien.barre@...ouvain.be> WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists