netdev - Re: [PATCH v2 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Aug 2014 16:33:51 +0200
From:	Richard Cochran <richardcochran@...il.com>
To:	"fugang.duan@...escale.com" <fugang.duan@...escale.com>
Cc:	"shawn.guo@...aro.org" <shawn.guo@...aro.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] net: fec: ptp: avoid register access when ipg
 clock is disabled

On Thu, Aug 14, 2014 at 09:26:45AM +0000, fugang.duan@...escale.com wrote:
> When ethx disable, all clocks are disabled. For gettime(), your mean that we check clock is on or not,
> If clock is disabled, return an error in .fec_ptp_gettime() ?

Yes.

> How did it in the delayed work ?

The work must run whenever the physical clock is runnning.

This is COMPLETELY INDEPENDENT from time stamping.

If your patch has anything with "fep->hwts_tx_en", then it is wrong.

> Thanks for your review, I am confused by your suggestion.

Just start and stop the work queue when you start and stop the
physical clock.

Is it clear now?

Thanks,
Richard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html