netdev - Re: [PATCH net v2 0/2] cbq: incorrectly low bandwidth blocks limited traffic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 19 Aug 2014 11:00:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	vvs@...allels.com
Cc:	netdev@...r.kernel.org, jhs@...atatu.com, eric.dumazet@...il.com,
	kuznet@....inr.ac.ru
Subject: Re: [PATCH net v2 0/2] cbq: incorrectly low bandwidth blocks
 limited traffic

From: Vasily Averin <vvs@...allels.com>
Date: Thu, 14 Aug 2014 12:27:29 +0400

> v2: patch description changes
> Fixes: f0f6ee1f70c4 ("cbq: incorrect processing of high limits")
> 
> Mainstream commit f0f6ee1f70c4 ("cbq: incorrect processing of high limits")
> have side effect: if cbq bandwidth setting is less than real interface
> throughput non-limited traffic can delay limited traffic for a very long time.
> 
> This happen because of q->now changes incorrectly in cbq_dequeue():
> in described scenario L2T is much greater than real time delay,
> and q->now gets an extra boost for each transmitted packet.
> 
> Accumulated boost prevents update q->now, and blocked class can wait
> very long time until (q->now >= cl->undertime) will be true again.
> 
> More detailed problem description can be found here:
> http://www.spinics.net/lists/netdev/msg292493.html
> 
> Following patches should fix the problem.

Series applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html