lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 20 Aug 2014 17:31:42 +0800 From: Zhu Yanjun <zyjzyj2000@...il.com> To: dborkman@...hat.com, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, vyasevich@...il.com, tuexen@...muenster.de, khandelwal.deepak.1987@...il.com, Yue.Tao@...driver.com, alexandre.dietsch@...driver.com, davem@...emloft.net, zyjzyj2000@...il.com Cc: Zhu Yanjun <Yanjun.Zhu@...driver.com> Subject: [PATCH V2] sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe Hi, Vlad && Deepak && Michael && David && Daniel V2: Following the advice from Daniel Borkmann, I modified the comments and short log. >From Michael && Deepak " lxr SCTP implementation, doesn't transit the path state to INACTIVE, if it was never confirmed. this leads to SCTP_PEER_ADDRESS_CHANGE notification after each failed probe from this time. Is there any specific reason to have same notification to SCTP User with each probe in RTO time period ? 806 case SCTP_TRANSPORT_DOWN: 807 /* If the transport was never confirmed, do not transition it 808 * to inactive state. Also, release the cached route since 809 * there may be a better route next time. 810 */ 811 if (transport->state != SCTP_UNCONFIRMED) 812 transport->state = SCTP_INACTIVE; http://lxr.free-electrons.com/source/net/sctp/associola.c#L806 ...... I would also only expect a SCTP_PEER_ADDRESS_CHANGE notification when a path state changes, not on every try. " I made a patch to disable sending SCTP_PEER_ADDRESS_CHANGE notification every try. Now the patch is in the attachment. Please check it. Zhu Yanjun Zhu Yanjun (1): sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe net/sctp/associola.c | 1 + 1 file changed, 1 insertion(+) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists