netdev - Re: [PATCH net] xen-netback: move netif_napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 25 Aug 2014 17:32:20 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	wei.liu2@...rix.com
Cc:	xen-devel@...ts.xen.org, netdev@...r.kernel.org, talex5@...il.com,
	ian.campbell@...rix.com
Subject: Re: [PATCH net] xen-netback: move netif_napi_add before binding
 interrupt

From: Wei Liu <wei.liu2@...rix.com>
Date: Mon, 25 Aug 2014 16:44:00 +0100

> Interrupt is enabled when bind_interdomain_evtchn_to_irqhandler returns.
> If there's interrupt pending interrupt handler is invoked.
> 
> NAPI needs to be initialised before binding interrupt otherwise the
> interrupt handler will try to scheduling a NAPI instance that is not
> initialised yet, resulting in kernel OOPS.
> 
> This fixes a regression introduced in ea2c5e13 ("xen-netback: move NAPI
> add/remove calls").
> 
> Ideally function calls to create kthreads should also be moved before
> binding but I intent to fix this regression with minimal changes and
> refactor the code with another patch.
> 
> Reported-by: Thomas Leonard <talex5@...il.com>
> Signed-off-by: Wei Liu <wei.liu2@...rix.com>
> Cc: Ian Campbell <ian.campbell@...rix.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html