lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 29 Aug 2014 11:18:16 -0700 From: Franky Lin <frankyl@...adcom.com> To: Geert Uytterhoeven <geert@...ux-m68k.org>, Brett Rudley <brudley@...adcom.com>, "John W. Linville" <linville@...driver.com>, "David S. Miller" <davem@...emloft.net> CC: <linux-wireless@...r.kernel.org>, <brcm80211-dev-list@...adcom.com>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] brcmfmac: BRCMFMAC should depend on HAS_DMA Hi Geert, On 8/29/2014 9:24 AM, Geert Uytterhoeven wrote: > If NO_DMA=y: > > drivers/built-in.o: In function `brcmf_msgbuf_release_array': > msgbuf.c:(.text+0x34dbbe): undefined reference to `dma_unmap_single' > drivers/built-in.o: In function `brcmf_proto_msgbuf_detach': > (.text+0x34dca4): undefined reference to `dma_free_coherent' > drivers/built-in.o: In function `brcmf_msgbuf_get_pktid': > msgbuf.c:(.text+0x34dd2a): undefined reference to `dma_unmap_single' > drivers/built-in.o: In function `brcmf_msgbuf_alloc_pktid': > msgbuf.c:(.text+0x34de12): undefined reference to `dma_map_single' > msgbuf.c:(.text+0x34de20): undefined reference to `dma_mapping_error' > drivers/built-in.o: In function `brcmf_msgbuf_remove_flowring': > msgbuf.c:(.text+0x34e3d6): undefined reference to `dma_free_coherent' > drivers/built-in.o: In function `brcmf_msgbuf_flowring_create': > msgbuf.c:(.text+0x34e4f8): undefined reference to `dma_alloc_coherent' > drivers/built-in.o: In function `brcmf_proto_msgbuf_attach': > (.text+0x34f5fe): undefined reference to `dma_alloc_coherent' > drivers/built-in.o: In function `brcmf_proto_msgbuf_attach': > (.text+0x34f798): undefined reference to `dma_free_coherent' > > Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org> > --- > drivers/net/wireless/brcm80211/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/brcm80211/Kconfig b/drivers/net/wireless/brcm80211/Kconfig > index b8e2561ea645..2e0da8925834 100644 > --- a/drivers/net/wireless/brcm80211/Kconfig > +++ b/drivers/net/wireless/brcm80211/Kconfig > @@ -19,7 +19,7 @@ config BRCMSMAC > > config BRCMFMAC > tristate "Broadcom IEEE802.11n embedded FullMAC WLAN driver" > - depends on CFG80211 > + depends on CFG80211A && HAS_DMA > select BRCMUTIL > ---help--- > This module adds support for embedded wireless adapters based on Thanks for reporting this. All complaints are from msgbuf code. So the dependency should belong to BRCMFMAC_PCIE not BRCMFMAC. Thanks, Franky -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists