netdev - Re: [PATCH net] bnx2x: Configure device endianity on driver load and reset endianity on removal.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 01 Sep 2014 14:53:14 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	manish.chopra@...gic.com
Cc:	netdev@...r.kernel.org, Ariel.Elior@...gic.com,
	Yuval.Mintz@...gic.com
Subject: Re: [PATCH net] bnx2x: Configure device endianity on driver load
 and reset endianity on removal.

From: Manish Chopra <manish.chopra@...gic.com>
Date: Mon, 1 Sep 2014 15:33:20 +0000

>> -----Original Message-----
>> This patch fixes this case from both ends:
>> 1) Return endianity to original values on shutdown (in case little endian kernel
>> boots after we shutdown).
>> 2) Do not rely on HW reset values when loading driver in little endian kernel
>>    but configure them explicitly (in case previous kernel was big endian and did
>> not reset the HW).
 ...
> David, Please drop this patch as it might create issue for VFs.
> I will send updated V2 patch with proper fix. 

I think part #2 is the only reasonable part of this patch, and that's
what you'll have to backport to -stable kernels to sort this out
properly.

Adding "unconfiguration" hacks into a driver to deal with driver bugs
is really not kosher, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html