netdev - Re: [PATCH net-next 0/3] fec: Do not use NULL pointer to indicate error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 02 Sep 2014 13:48:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	festevam@...il.com
Cc:	linux@....linux.org.uk, B38611@...escale.com,
	netdev@...r.kernel.org, fabio.estevam@...escale.com
Subject: Re: [PATCH net-next 0/3] fec: Do not use NULL pointer to indicate
 error

From: Fabio Estevam <festevam@...il.com>
Date: Mon,  1 Sep 2014 22:12:52 -0300

> Using IS_ERR() to indicate error can simplify the code a bit, so let's use
> it when appropriate.

I would rather you not do this.

Generally speaking we should not leave pointer error values in
structure pointers.

It's just asking for someone to later accidently kfree or
release the "object" because pointer errors evaluate to
non-NULL.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html