netdev - Re: [PATCH 4/9] net: Pass a "more" indication down into netdev_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 01 Sep 2014 18:41:20 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	therbert@...gle.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 4/9] net: Pass a "more" indication down into
 netdev_start_xmit() code paths.

From: Tom Herbert <therbert@...gle.com>
Date: Mon, 1 Sep 2014 18:21:57 -0700

> On Mon, Sep 1, 2014 at 3:24 PM, David Miller <davem@...emloft.net> wrote:
>> +                                             bool more)
>>  {
>> -       skb->xmit_more = 0;
>> +       skb->xmit_more = more ? 1 : 0;
> 
> Maybe just
> 
> skb->xmit_more = more;

I'm just being overly cautious because we're storing a boolean into
an integer bitfield.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html