lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 2 Sep 2014 05:47:49 +0000 From: Yuval Mintz <Yuval.Mintz@...gic.com> To: David Miller <davem@...emloft.net>, Manish Chopra <manish.chopra@...gic.com> CC: netdev <netdev@...r.kernel.org>, Ariel Elior <Ariel.Elior@...gic.com> Subject: RE: [PATCH net] bnx2x: Configure device endianity on driver load and reset endianity on removal. >> This patch fixes this case from both ends: >>> 1) Return endianity to original values on shutdown (in case little endian kernel >>> boots after we shutdown). >>> 2) Do not rely on HW reset values when loading driver in little endian kernel >>> but configure them explicitly (in case previous kernel was big endian and did >>> not reset the HW). ... >> David, Please drop this patch as it might create issue for VFs. >> I will send updated V2 patch with proper fix. >I think part #2 is the only reasonable part of this patch, and that's >what you'll have to backport to -stable kernels to sort this out >properly. >Adding "unconfiguration" hacks into a driver to deal with driver bugs >is really not kosher, sorry. Why call this a hack? It's true #2 can solve the issue on its own for new kernels, but given the various existing distros out there (that don't include the fix) the effort of supporting those by adding #1 seems to be very small. I wouldn't say it's not kosher; more like milchig. But then again, this is your domain and in truth constellations needing this fix are quite odd. If you insist we'll throw #1 away.-- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists