[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 9 Sep 2014 17:39:52 +0300
From: Roger Quadros <rogerq@...com>
To: Marc Kleine-Budde <mkl@...gutronix.de>, <wg@...ndegger.com>
CC: <tony@...mide.com>, <tglx@...utronix.de>, <mugunthanvnm@...com>,
<george.cherian@...com>, <balbi@...com>, <nsekhar@...com>,
<nm@...com>, <sergei.shtylyov@...entembedded.com>,
<linux-omap@...r.kernel.org>, <linux-can@...r.kernel.org>,
<netdev@...r.kernel.org>
Subject: Re: [PATCH v2 1/3] can: c_can_platform: Fix c_can_hw_raminit_ti()
and add timeout
On 09/09/2014 05:34 PM, Marc Kleine-Budde wrote:
> On 09/09/2014 04:31 PM, Roger Quadros wrote:
>> Pass the correct 'mask' and 'value' bits to c_can_hw_raminit_wait_ti().
>> They seem to have been swapped in the usage instances.
>
> Can you split this fix into a seperate patch, please.
OK.
>
>> TI's RAMINIT DONE mechanism is buggy and may not always be
>> set after the START bit is set. So add a timeout mechanism to
>> c_can_hw_raminit_wait_ti().
>
> What should happen if the timeout occurs?
I'm not sure yet. I will verify if the hardware still works or not in that case.
If it doesn't work then we should fail.
cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists