netdev - Re: [Patch v3 net-next 09/12] net: fec: change FEC alignment according to i.mx6 sx requirement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 12 Sep 2014 15:45:01 -0500
From:	Zhi Li <lznuaa@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	"Frank.Li@...escale.com" <Frank.Li@...escale.com>,
	Duan Fugang-B38611 <b38611@...escale.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Shawn Guo <shawn.guo@...aro.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Russell King - ARM Linux <linux@....linux.org.uk>
Subject: Re: [Patch v3 net-next 09/12] net: fec: change FEC alignment
 according to i.mx6 sx requirement

On Fri, Sep 12, 2014 at 3:40 PM, David Miller <davem@...emloft.net> wrote:
> From: Frank Li <Frank.Li@...escale.com>
> Date: Thu, 11 Sep 2014 02:30:42 +0800
>
>> +
>> +     unsigned tx_align;
>> +     unsigned rx_align;
>>  };
>
> Please always fully write out "unsigned int" rather than just "unsigned".
>
>> @@ -2399,6 +2393,7 @@ fec_enet_alloc_rxq_buffers(struct net_device *ndev, unsigned int queue)
>>       struct sk_buff *skb;
>>       struct bufdesc  *bdp;
>>       struct fec_enet_priv_rx_q *rxq;
>> +     unsigned off;
>
> Likewise.

Okay, I will fix it next version.

best regards
Frank Li
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html