netdev - Re: [PATCH] pktgen: nowait parameter.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 12 Sep 2014 17:52:41 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	rusty@...tcorp.com.au
Cc:	netdev@...r.kernel.org, brouer@...hat.com, minipli@...glemail.com
Subject: Re: [PATCH] pktgen: nowait parameter.

From: Rusty Russell <rusty@...tcorp.com.au>
Date: Thu, 11 Sep 2014 09:07:29 +0930

> David Miller <davem@...emloft.net> writes:
>> From: Rusty Russell <rusty@...tcorp.com.au>
>> Date: Wed, 03 Sep 2014 13:50:01 +0930
>>
>> BTW, wrt. holding onto TX frames for unbounded amounts of time, I
>> think this is a bad idea even with skb_orphan().  There are resources
>> from the SKB you are hanging onto which can stall the removal of
>> modules indefinitely, such as netfilter references.
> 
> We could certainly have a once-a-second timer which did this, but should
> skb_orphan() do that work instead?

It would definitely improve the situation.

I've discussed a few times with Herbert Xu the idea of using hrtimers
since we have those, to do something more clever and timely.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html