lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 12 Sep 2014 19:09:48 +0200 From: Hannes Frederic Sowa <hannes@...essinduktion.org> To: Cong Wang <cwang@...pensource.com> Cc: Alexei Starovoitov <alexei.starovoitov@...il.com>, netdev <netdev@...r.kernel.org>, Eric Dumazet <eric.dumazet@...il.com>, Markos Chandras <markos.chandras@...tec.com>, Martin Schwidefsky <schwidefsky@...ibm.com>, Daniel Borkmann <dborkman@...hat.com>, Denis Kirjanov <kda@...ux-powerpc.org> Subject: Re: [PATCH net-next v2] net: filter: constify detection of pkt_type_offset On Fr, 2014-09-12 at 10:06 -0700, Cong Wang wrote: > On Fri, Sep 12, 2014 at 9:06 AM, Alexei Starovoitov > <alexei.starovoitov@...il.com> wrote: > > On Fri, Sep 12, 2014 at 02:04:43PM +0200, Hannes Frederic Sowa wrote: > >> Currently we have 2 pkt_type_offset functions doing the same thing and > >> spread across the architecture files. Remove those and replace them > >> with a PKT_TYPE_OFFSET macro helper which gets the constant value from a > >> zero sized sk_buff member right in front of the bitfield with offsetof. > >> This new offset marker does not change size of struct sk_buff. > >> > >> Cc: Eric Dumazet <eric.dumazet@...il.com> > >> Cc: Markos Chandras <markos.chandras@...tec.com> > >> Cc: Martin Schwidefsky <schwidefsky@...ibm.com> > >> Cc: Daniel Borkmann <dborkman@...hat.com> > >> Cc: Alexei Starovoitov <alexei.starovoitov@...il.com> > >> Signed-off-by: Denis Kirjanov <kda@...ux-powerpc.org> > >> Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org> > >> --- > >> > >> v2) Incorporated Daniel's feedback. I first misinterpreted the feedback > >> as something not related to pkt_type_offset. > > > > Thanks! It's a nice cleanup. > > > > Acked-by: Alexei Starovoitov <ast@...mgrid.com> > > Wait... Isn't there a same patch before? > > http://www.spinics.net/lists/netdev/msg294839.html > > Maybe not exactly the same, but roughly same from the stats.... Sure, he asked me to send it and I included his signed-off. I think I did that correctly? Bye, Hannes -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists