netdev - Re: [PATCH net-next v2 1/4] openvswitch: refactor ovs flow extract API.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 15 Sep 2014 10:23:40 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 1/4] openvswitch: refactor ovs flow extract API.

On Sat, Sep 13, 2014 at 1:47 PM, David Miller <davem@...emloft.net> wrote:
> From: Pravin B Shelar <pshelar@...ira.com>
> Date: Thu, 11 Sep 2014 16:28:04 -0700
>
>> @@ -250,7 +251,7 @@ void ovs_dp_process_received_packet(struct vport *p, struct sk_buff *skb)
>>       stats = this_cpu_ptr(dp->stats_percpu);
>>
>>       /* Extract flow from 'skb' into 'key'. */
>> -     error = ovs_flow_extract(skb, p->port_no, &key);
>> +     error = ovs_flow_key_extract(skb, &key);
>>       if (unlikely(error)) {
>>               kfree_skb(skb);
>>               return;
> ...
>> @@ -611,5 +604,35 @@ int ovs_flow_extract(struct sk_buff *skb, u16 in_port, struct sw_flow_key *key)
>>               }
>>       }
>>
>> +     OVS_CB(skb)->pkt_key = key;
>>       return 0;
>
> Wow, have you really been putting pointers to kernel stack variables
> into the SKB control block all this time?
>
> That's error prone as well as asking for trouble.
>
Good point.

> Please adjust the code to not do this.

But this is significantly different than the patch series. If I change
this patch, I will need to change all patches in this series. So I
would add one patch at the end of this series to fix this issue.

Thanks,
Pravin.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html