netdev - Re: [PATCH 1/1] net: allow macvlans to move to net namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Sep 2014 13:55:32 -0700
From:	Cong Wang <cwang@...pensource.com>
To:	Francesco Ruggeri <fruggeri@...stanetworks.com>
Cc:	netdev <netdev@...r.kernel.org>,
	Francesco Ruggeri <fruggeri@...sta.com>,
	Florian Westphal <fw@...len.de>,
	chenweilong <chenweilong@...wei.com>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH 1/1] net: allow macvlans to move to net namespace

On Wed, Sep 17, 2014 at 11:12 AM, Francesco Ruggeri
<fruggeri@...stanetworks.com> wrote:
> diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
> index a969555..7652fd1 100644
> --- a/drivers/net/macvlan.c
> +++ b/drivers/net/macvlan.c
> @@ -806,6 +806,7 @@ static netdev_features_t macvlan_fix_features(struct net_device *dev,
>                                              features,
>                                              mask);
>         features |= ALWAYS_ON_FEATURES;
> +       features &= ~NETIF_F_NETNS_LOCAL;
>
>         return features;
>  }


Even if we have some other way to clear this flag (maybe clearing it
in mask etc.),
explicitly clearing it is more readable, I don't want to spin my head to
read netdev_increment_features(), so,

Acked-by: Cong Wang <cwang@...pensource.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html