netdev - Re: [PATCH net-next v2] fec: Staticize fec_enet_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 19 Sep 2014 13:55:14 -0500
From:	Zhi Li <lznuaa@...il.com>
To:	Fabio Estevam <fabio.estevam@...escale.com>
Cc:	David Miller <davem@...emloft.net>,
	"Frank.Li@...escale.com" <Frank.Li@...escale.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2] fec: Staticize fec_enet_select_queue()

On Fri, Sep 19, 2014 at 12:59 PM, Fabio Estevam
<fabio.estevam@...escale.com> wrote:
> fec_enet_select_queue() is only used locally, so mark it as 'static' to fix the
> following sparse warning:
>
> drivers/net/ethernet/freescale/fec_main.c:2707:5: warning: symbol 'fec_enet_select_queue' was not declared. Should it be static?
>
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>

Acked-by: Frank Li <Frank.Li@...escale.com>

> ---
> Changes since v1:
> - Make checkpatch happy
>
>  drivers/net/ethernet/freescale/fec_main.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index 6e93336..2389dff 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -2704,8 +2704,9 @@ static int fec_set_features(struct net_device *netdev,
>         return 0;
>  }
>
> -u16 fec_enet_select_queue(struct net_device *ndev, struct sk_buff *skb,
> -                         void *accel_priv, select_queue_fallback_t fallback)
> +static u16 fec_enet_select_queue(struct net_device *ndev, struct sk_buff *skb,
> +                                void *accel_priv,
> +                                select_queue_fallback_t fallback)
>  {
>         return skb_tx_hash(ndev, skb);
>  }
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html