netdev - Re: [PATCH v7 ethtool 2/2] ethtool: Support for configurable RSS hash key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 21 Sep 2014 21:52:31 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Venkat Duvvuru <VenkatKumar.Duvvuru@...lex.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v7 ethtool 2/2] ethtool: Support for configurable RSS
 hash key

On Tue, 2014-07-22 at 17:51 +0530, Venkat Duvvuru wrote:
> This ethtool patch will primarily implement the parser for the options provided
> by the user for get and set rxfh before invoking the ioctl.
> This patch also has
> 1. Ethtool man page changes which describes the Usage of
>    get and set rxfh options.
> 2. Test cases for get and set rxfh in test-cmdline.c
> 
> Signed-off-by: Venkat Duvvuru <VenkatKumar.Duvvuru@...lex.com>
[...]

FAIL: test-cmdline
==================

E: ethtool --rxfh devname hkey foo returns 0
E: ethtool -X devname hkey foo returns 0

The problem with these test cases is we can't parse the hash key (and
reject "foo") until after we start sending ioctls.  test-cmdline doesn't
include any mocking of ioctls, but instead makes each test successful if
it calls an ioctl.

Ben.

-- 
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
                                                              - Albert Camus

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)