netdev - Re: [PATCH net-next] tcp: add coalescing attempt in tcp_ofo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 23 Sep 2014 12:48:29 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, ncardwell@...gle.com, ycheng@...gle.com
Subject: Re: [PATCH net-next] tcp: add coalescing attempt in tcp_ofo_queue()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 19 Sep 2014 08:26:20 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> In order to make TCP more resilient in presence of reorders, we need
> to allow coalescing to happen when skbs from out of order queue are
> transferred into receive queue. LRO/GRO can be completely canceled
> in some pathological cases, like per packet load balancing on aggregated
> links.
> 
> I had to move tcp_try_coalesce() up in the file above tcp_ofo_queue()
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
> 
> Note: I am not sure we really need this part in tcp_try_coalesce(),
> as I doubt we need ack_seq in the skbs stored in receive queues ?
> 
> 	TCP_SKB_CB(to)->ack_seq = TCP_SKB_CB(from)->ack_seq;

Yes, it's used only for incoming ACKs.  But better safe than
sorry. :-)

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html