netdev - Re: [PATCH net-next v3] fec: Remove fec_enet_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 26 Sep 2014 15:22:14 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	festevam@...il.com
Cc:	Frank.Li@...escale.com, netdev@...r.kernel.org,
	fabio.estevam@...escale.com
Subject: Re: [PATCH net-next v3] fec: Remove fec_enet_select_queue()

From: Fabio Estevam <festevam@...il.com>
Date: Mon, 22 Sep 2014 17:55:29 -0300

> From: Fabio Estevam <fabio.estevam@...escale.com>
> 
> Sparse complains about fec_enet_select_queue() not being static.
> 
> Feedback from David Miller [1] was to remove this function instead of making it
> static:
> 
> "Please just delete this function.
> 
> It's overriding code which does exactly the same thing.
> 
> Actually, more precisely, this code is duplicating code in a way that
> bypasses many core facilitites of the networking.  For example, this
> override means that socket based flow steering, XPS, etc. are all
> not happening on these devices.
> 
> Without ->ndo_select_queue(), the flow dissector does __netdev_pick_tx
> which is exactly what you want to happen."
> 
> [1] http://www.spinics.net/lists/netdev/msg297653.html
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>

Looks a lot better, applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html