lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 30 Sep 2014 18:10:51 +0800 From: Chen Gang <gang.chen.5i5j@...il.com> To: David Vrabel <david.vrabel@...rix.com>, konrad.wilk@...cle.com, ian.campbell@...rix.com, wei.liu2@...rix.com, boris.ostrovsky@...cle.com, bhelgaas@...gle.com, jgross@...e.com, yongjun_wei@...ndmicro.com.cn, mukesh.rathor@...cle.com CC: xen-devel@...ts.xenproject.org, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, linux-pci@...r.kernel.org, linux-scsi@...r.kernel.org, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] xen/xenbus: Use 'void' instead of 'int' for the return of xenbus_switch_state() On 9/30/14 17:55, David Vrabel wrote: > On 26/09/14 17:36, Chen Gang wrote: >> When xenbus_switch_state() fails, it will call xenbus_switch_fatal() >> internally, so need not return any status value, then use 'void' instead >> of 'int' for xenbus_switch_state() and __xenbus_switch_state(). >> >> Also need be sure that all callers which check the return value must let >> 'err' be 0. >> >> And also need change the related comments for xenbus_switch_state(). > > Since this patch does not fix a bug and there is no unanimous agreement > on the API change I'm not going to apply it (nor the previous version). > OK, at least for me, it is no problems. But I still recommend to improve it in the future, it is not a good idea to let all related things remain in current condition (for me, at lease need some related code comments for it). Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists