lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 3 Oct 2014 12:35:05 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Andy Whitcroft <apw@...onical.com>, Andrew Morton <akpm@...ux-foundation.org> Cc: Joe Perches <joe@...ches.com>, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org, gregkh@...uxfoundation.org Subject: [patch] checkpatch: remove the ether_addr_copy warning Most people sending checkpatch.pl fixes don't know how to verify the alignment. This checkpatch warning just encourages newbies to try introduce bugs. Patch submitters tell us that they just sed the code and it's the job for the maintainer to check that it's correct. If you want to work on these then you can get the same information by typing `grep -nw memcpy drivers/net/ -R | grep ETH_ALEN` Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 52a223e..d540dd4 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -4698,16 +4698,6 @@ sub process { } } -# Check for memcpy(foo, bar, ETH_ALEN) that could be ether_addr_copy(foo, bar) - if ($^V && $^V ge 5.10.0 && - $line =~ /^\+(?:.*?)\bmemcpy\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/s) { - if (WARN("PREFER_ETHER_ADDR_COPY", - "Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)\n" . $herecurr) && - $fix) { - $fixed[$fixlinenr] =~ s/\bmemcpy\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/ether_addr_copy($2, $7)/; - } - } - # typecasts on min/max could be min_t/max_t if ($^V && $^V ge 5.10.0 && defined $stat && -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists