netdev - Re: [PATCH] team: avoid race condition in scheduling delayed work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 04 Oct 2014 20:51:28 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	joe.lawrence@...atus.com
Cc:	netdev@...r.kernel.org, jiri@...nulli.us
Subject: Re: [PATCH] team: avoid race condition in scheduling delayed work

From: Joe Lawrence <joe.lawrence@...atus.com>
Date: Fri, 3 Oct 2014 09:58:34 -0400

> When team_notify_peers and team_mcast_rejoin are called, they both reset
> their respective .count_pending atomic variable. Then when the actual
> worker function is executed, the variable is atomically decremented.
> This pattern introduces a potential race condition where the
> .count_pending rolls over and the worker function keeps rescheduling
> until .count_pending decrements to zero again:
 ...
> Instead of assigning a new value to .count_pending, use atomic_add to
> tack-on the additional desired worker function invocations.
> 
> Signed-off-by: Joe Lawrence <joe.lawrence@...atus.com>
> Acked-by: Jiri Pirko <jiri@...nulli.us>
> Fixes: fc423ff00df3a19554414ee ("team: add peer notification")
> Fixes: 492b200efdd20b8fcfdac87 ("team: add support for sending multicast rejoins")

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html