netdev - RE: [net v2 3/8] net/fsl_pq_mdio: Replace spin_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Oct 2014 08:12:42 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Claudiu Manoil' <claudiu.manoil@...escale.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	"David S. Miller" <davem@...emloft.net>,
	Xiubo Li <Li.Xiubo@...escale.com>,
	Shruti Kanetkar <Shruti@...escale.com>,
	"Kim Phillips" <kim.phillips@...escale.com>
Subject: RE: [net v2 3/8] net/fsl_pq_mdio: Replace spin_event_timeout() with
 arch independent

From: netdev-owner@...r.kernel. 
> spin_event_timeout() is PPC dependent, use an arch independent
> equivalent instead.

I think you should white a local function/#define that expands to spin_event_timeout()
on ppc and to the code below you are substituting on other architectures.

>  	/* Wait for the transaction to finish */
> -	status = spin_event_timeout(!(ioread32be(&regs->miimind) &
> -				    MIIMIND_BUSY), MII_TIMEOUT, 0);
> +	timeout = MII_TIMEOUT;
> +	while ((ioread32be(&regs->miimind) & MIIMIND_BUSY) && timeout) {
> +		cpu_relax();
> +		timeout--;
> +	}

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html