lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Oct 2014 01:43:25 +0200 From: "Luis R. Rodriguez" <mcgrof@...not-panic.com> To: Dmitry Torokhov <dmitry.torokhov@...il.com> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Wu Zhangjin <falcon@...zu.com>, Takashi Iwai <tiwai@...e.de>, Tejun Heo <tj@...nel.org>, Arjan van de Ven <arjan@...ux.intel.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Oleg Nesterov <oleg@...hat.com>, hare <hare@...e.com>, Andrew Morton <akpm@...ux-foundation.org>, Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>, Joseph Salisbury <joseph.salisbury@...onical.com>, Benjamin Poirier <bpoirier@...e.de>, Santosh Rastapur <santosh@...lsio.com>, Kay Sievers <kay@...y.org>, One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>, Tim Gardner <tim.gardner@...onical.com>, Pierre Fersing <pierre-fersing@...rref.org>, Nagalakshmi Nandigama <nagalakshmi.nandigama@...gotech.com>, Praveen Krishnamoorthy <praveen.krishnamoorthy@...gotech.com>, Sreekanth Reddy <sreekanth.reddy@...gotech.com>, Abhijit Mahajan <abhijit.mahajan@...gotech.com>, Casey Leedom <leedom@...lsio.com>, Hariprasad S <hariprasad@...lsio.com>, "mpt-fusionlinux.pdl" <MPT-FusionLinux.pdl@...gotech.com>, Linux SCSI List <linux-scsi@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [RFC v2 2/6] driver-core: add driver async_probe support > diff --git a/drivers/base/bus.c b/drivers/base/bus.c > index 83e910a..49fe573 100644 > --- a/drivers/base/bus.c > +++ b/drivers/base/bus.c > @@ -10,6 +10,7 @@ > * > */ > > +#include <linux/async.h> > #include <linux/device.h> > #include <linux/module.h> > #include <linux/errno.h> > @@ -547,15 +548,12 @@ void bus_probe_device(struct device *dev) > { > struct bus_type *bus = dev->bus; > struct subsys_interface *sif; > - int ret; > > if (!bus) > return; > > - if (bus->p->drivers_autoprobe) { > - ret = device_attach(dev); > - WARN_ON(ret < 0); > - } > + if (bus->p->drivers_autoprobe) > + device_initial_probe(dev); > > mutex_lock(&bus->p->mutex); > list_for_each_entry(sif, &bus->p->interfaces, node) > @@ -657,6 +655,17 @@ static ssize_t uevent_store(struct device_driver *drv, const char *buf, > } > static DRIVER_ATTR_WO(uevent); Based on my review with my latest changes this is what I was missing, I'll be sure to address this. Luis -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists