lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Oct 2014 22:05:41 +0200 (CEST) From: Fabian Frederick <fabf@...net.be> To: Johannes Berg <johannes@...solutions.net> Cc: linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, "John W. Linville" <linville@...driver.com> Subject: Re: [PATCH 1/1 net-next] mac80211: remove unnecessary null test before debugfs_remove > On 21 October 2014 at 21:06 Johannes Berg <johannes@...solutions.net> wrote: > > > On Tue, 2014-10-21 at 18:20 +0200, Fabian Frederick wrote: > > Fix checkpatch warnings: > > > > WARNING: debugfs_remove(NULL) is safe this check is probably not > >required > > I'll apply this; however, I think that checkpatch is a just tool, and > the commit message should reflect why you're changing the code. > Presumably you're not doing it to make the tool happy, but to address an > issue that the tool pointed out, so I think in most cases the commit > message should state the former, not the latter. > > Note that in this particular case the NULL check check could be there to > avoid a memory write (which can be significant depending on the context) > so blindly doing what the tool suggested wouldn't always be a good idea. > > johannes > Thanks Johannes, Maybe you can replace commit message with: " This patch removes NULL check before debugfs_remove. That function already does that check and is only called during key management so we can add some memory writes. " I can also resubmit patch if necessary. Regards, Fabian -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists