netdev - Re: [PATCH net] udptunnel: Add SKB_GSO_UDP_TUNNEL during gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 Nov 2014 14:33:48 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jesse@...ira.com
Cc:	jay.vosburgh@...onical.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] udptunnel: Add SKB_GSO_UDP_TUNNEL during
 gro_complete.

From: Jesse Gross <jesse@...ira.com>
Date: Fri, 7 Nov 2014 19:54:51 -0800

> On Fri, Nov 7, 2014 at 5:51 PM, Jay Vosburgh <jay.vosburgh@...onical.com> wrote:
>> Jesse Gross <jesse@...ira.com> wrote:
>>
>>>When doing GRO processing for UDP tunnels, we never add
>>>SKB_GSO_UDP_TUNNEL to gso_type - only the type of the inner protocol
>>>is added (such as SKB_GSO_TCPV4). The result is that if the packet is
>>>later resegmented we will do GSO but not treat it as a tunnel. This
>>>results in UDP fragmentation and since that is not the original layout
>>>of the skb, a panic in skb_segment().
>>>
>>>Reported-by: Jay Vosburgh <jay.vosburgh@...onical.com>
>>>Signed-off-by: Jesse Gross <jesse@...ira.com>
>>>---
>>>This problem occurs back to 3.14 for VXLAN but the FOU portion needs to
>>>be removed for kernels other than the 'net' tree.
>>
>>         This patch does not resolve the problem when applied to a
>> 3.17-ish kernel; the panic message is below, and appears to be
>> unchanged.
> 
> Hmm, OK, thanks for testing. I think this patch is probably still good
> to apply as it may solve a problem after we get this one figured out.

But if you want that to happen, you'll have to adjust the commit
message because it doesn't fix the crash reported by Jay at all.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html