[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 11 Nov 2014 18:12:49 +0000
From: Ben Hutchings <ben@...adent.org.uk>
To: Jesse Brandeburg <jesse.brandeburg@...el.com>
Cc: netdev@...r.kernel.org
Subject: Re: question about ethtool bits?
On Mon, 2014-11-10 at 12:47 -0800, Jesse Brandeburg wrote:
> Ben et al,
>
> So, I was just looking at adding some more types/speeds to
> ethtool.h and noticed we are about out of bits in ecmd->advertising
> (and others), which are declared u32.
>
> We currently have room for one more type (bit 31) and then all 32 bits
> will be full.
Right, I've been seeing this coming for a while.
[...]
> There are two u32's reserved at the end of ethtool_cmd.
>
> Suggestions?
Any extension needs to be applied to all of advertising, supported and
lp_advertising. So we could take 6 of the 8 reserved bytes and extend
them all by 16 bits.
Whoever does this should add getter/setter functions, as has been done
with the extension of speed.
Ben.
--
Ben Hutchings
Experience is directly proportional to the value of equipment destroyed.
- Carolyn Scheppner
Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)
Powered by blists - more mailing lists