[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 11 Nov 2014 14:18:33 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: joe@...ches.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
courmisch@...il.com, nicolas.dichtel@...nd.com
Subject: Re: [PATCH V2 net-next] net: Convert LIMIT_NETDEBUG to
net_dbg_ratelimited
From: Joe Perches <joe@...ches.com>
Date: Tue, 11 Nov 2014 10:59:17 -0800
> Use the more common dynamic_debug capable net_dbg_ratelimited
> and remove the LIMIT_NETDEBUG macro.
>
> All messages are still ratelimited.
>
> Some KERN_<LEVEL> uses are changed to KERN_DEBUG.
>
> This may have some negative impact on messages that were
> emitted at KERN_INFO that are not not enabled at all unless
> DEBUG is defined or dynamic_debug is enabled. Even so,
> these messages are now _not_ emitted by default.
>
> This also eliminates the use of the net_msg_warn sysctl
> "/proc/sys/net/core/warnings". For backward compatibility,
> the sysctl is not removed, but it has no function. The extern
> declaration of net_msg_warn is removed from sock.h and made
> static in net/core/sysctl_net_core.c
>
> Miscellanea:
>
> o Update the sysctl documentation
> o Remove the embedded uses of pr_fmt
> o Coalesce format fragments
> o Realign arguments
>
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>
> V2: Remove the EXPORT_SYMBOL for net_msg_warn and make
> it a static in net/core/sysctl_net_core.c
Applied, thanks a lot Joe.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists