netdev - Re: [PATCH resent] net: ppp: Don't call bpf_prog_create() in ppp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 11 Nov 2014 15:15:38 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	tiwai@...e.de
Cc:	netdev@...r.kernel.org, paulus@...ba.org,
	linux-ppp@...r.kernel.org, stefan.seyfried@...glemail.com
Subject: Re: [PATCH resent] net: ppp: Don't call bpf_prog_create() in
 ppp_lock

From: Takashi Iwai <tiwai@...e.de>
Date: Mon, 10 Nov 2014 11:50:21 +0100

> In ppp_ioctl(), bpf_prog_create() is called inside ppp_lock, which
> eventually calls vmalloc() and hits BUG_ON() in vmalloc.c.  This patch
> works around the problem by moving the allocation outside the lock.
> 
> The bug was revealed by the recent change in net/core/filter.c, as it
> allocates via vmalloc() instead of kmalloc() now.
> 
> Reported-and-tested-by: Stefan Seyfried <stefan.seyfried@...glemail.com>
> Signed-off-by: Takashi Iwai <tiwai@...e.de>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html