netdev - Re: [Patch net-next] net: remove netif_set_real_num_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Nov 2014 13:10:24 +0000
From:	Edward Cree <ecree@...arflare.com>
To:	Cong Wang <xiyou.wangcong@...il.com>
CC:	<netdev@...r.kernel.org>, Eric Dumazet <eric.dumazet@...il.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [Patch net-next] net: remove netif_set_real_num_rx_queues()

On 10/11/14 19:35, Cong Wang wrote:
> vlan was the only user of netif_set_real_num_rx_queues(),
> but it no longer calls it after
> commit 4af429d29b341bb1735f04c2fb960178 ("vlan: lockless transmit path").
> So we can just remove it.
>
> Cc: Eric Dumazet <eric.dumazet@...il.com>
> Cc: David S. Miller <davem@...emloft.net>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
>
> ---
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 888d551..4a6f770 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -2762,23 +2762,6 @@ static inline int netif_set_real_num_rx_queues(struct net_device *dev,
>  }
>  #endif
>  
> -static inline int netif_copy_real_num_queues(struct net_device *to_dev,
> -					     const struct net_device *from_dev)
Patch title says you're removing _set_ but body only removes _copy_. 
Which one is right?
> -{
> -	int err;
> -
> -	err = netif_set_real_num_tx_queues(to_dev,
> -					   from_dev->real_num_tx_queues);
> -	if (err)
> -		return err;
> -#ifdef CONFIG_SYSFS
> -	return netif_set_real_num_rx_queues(to_dev,
> -					    from_dev->real_num_rx_queues);
> -#else
> -	return 0;
> -#endif
> -}
> -
>  #ifdef CONFIG_SYSFS
>  static inline unsigned int get_netdev_rx_queue_index(
>  		struct netdev_rx_queue *queue)
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html