netdev - Re: [net-next PATCH v3 0/5] Replace __skb_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 12 Nov 2014 00:11:29 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	alexander.h.duyck@...hat.com
Cc:	netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	leedom@...lsio.com, hariprasad@...lsio.com,
	donald.c.skidmore@...el.com, oliver@...kum.org, balbi@...com,
	matthew.vick@...el.com, mgorman@...e.de,
	jeffrey.t.kirsher@...el.com
Subject: Re: [net-next PATCH v3 0/5] Replace __skb_alloc_pages with simpler
 function

From: Alexander Duyck <alexander.h.duyck@...hat.com>
Date: Tue, 11 Nov 2014 09:26:26 -0800

> This patch series replaces __skb_alloc_pages with a much simpler function,
> __dev_alloc_pages.  The main difference between the two is that
> __skb_alloc_pages had an sk_buff pointer that was being passed as NULL in
> call places where it was called.  In a couple of cases the NULL was passed
> by variable and this led to unnecessary code being run.
> 
> As such in order to simplify things the __dev_alloc_pages call only takes a
> mask and the page order being requested.  In addition it takes advantage of
> several behaviors already built into the page allocator so that it can just
> set GFP flags unconditionally.
> 
> v2: Renamed functions to dev_alloc_page(s) instead of netdev_alloc_page(s)
>     Removed __GFP_COLD flag from usb code as it was redundant
> v3: Update patch descriptions and subjects to match changes in v2

Series applied, thanks Alexander.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html