netdev - Re: [PATCH net-next v2] ipvlan: Initial check-in of the IPVLAN driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Nov 2014 00:48:23 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	maheshb@...gle.com
Cc:	netdev@...r.kernel.org, edumazet@...gle.com, maze@...gle.com,
	chavey@...gle.com, thockin@...gle.com, brandon.philips@...eos.com,
	xemul@...allels.com
Subject: Re: [PATCH net-next v2] ipvlan: Initial check-in of the IPVLAN
 driver.

From: Mahesh Bandewar <maheshb@...gle.com>
Date: Tue, 18 Nov 2014 21:27:48 -0800

> On Tue, Nov 18, 2014 at 12:54 PM, David Miller <davem@...emloft.net> wrote:
>>
>> From: Mahesh Bandewar <maheshb@...gle.com>
>> Date: Sun, 16 Nov 2014 22:27:14 -0800
>>
>> > +/* Define IPVL_DEBUG and set the appropriate dbg_level for debugging. */
>> > +#ifdef       IPVL_DEBUG
>> > +/*
>> > + * 1 : non-datapath debugging
>> > + * 2 : Custom
>> > + * 3 : function enters and exists.
>> > + * 4 : printk in data path (be careful!)
>> > + */
>> > +#define IPVL_DBG_LEVEL 1
>> > +#define ipvlan_dbg(level, msg...)    do { \
>> > +                                             if (level <= IPVL_DBG_LEVEL) \
>> > +                                             printk(KERN_DEBUG msg); \
>> > +                                     } while (0)
>> > +#else
>> > +#define ipvlan_dbg(level, msg...) do { ; } while (0)
>> > +#endif
>>
>> The day of having code use custom local debug logging facilities is long
>> gone, please use a standard mechanism for this rather than home cooked
>> reimplementations.
>>
> Do you mean pr_err() / pr_warn() / pr_debug() etc.? or something else?

And netdev_dbg(), etc.

And about sysfs, we're not having two ways to do the same exact
thing.  Whatever functionality you want to provide, implement it
via netlink and that's the end of it.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html