netdev - Re: [PATCH net-next] ipvlan: fix sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 26 Nov 2014 15:13:50 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	maheshb@...gle.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ipvlan: fix sparse warnings

From: Mahesh Bandewar <maheshb@...gle.com>
Date: Tue, 25 Nov 2014 21:24:43 -0800

> Fix sparse warnings reported by kbuild robot
> 
> drivers/net/ipvlan/ipvlan_main.c:172:13: warning: symbol 'ipvlan_start_xmit' was not declared. Should it be static?
> drivers/net/ipvlan/ipvlan_main.c:256:33: warning: incorrect type in initializer (different address spaces)
> drivers/net/ipvlan/ipvlan_main.c:256:33:    expected void const [noderef] <asn:3>*__vpp_verify
> drivers/net/ipvlan/ipvlan_main.c:256:33:    got struct ipvl_pcpu_stats *<noident>
> drivers/net/ipvlan/ipvlan_main.c:544:5: warning: symbol 'ipvlan_link_register' was not declared. Should it be static
> 
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>

Applied, can you please fix the build failures that have been
reported?  Those are more important.  Namely:

====================
Building with the attached random configuration file,

In file included from drivers/net/ipvlan/ipvlan.h:27:0,
                 from drivers/net/ipvlan/ipvlan_core.c:10:
include/net/gre.h: In function ‘gre_handle_offloads’:
include/net/gre.h:42:2: error: implicit declaration of function
‘iptunnel_handle_offloads’ [-Werror=implicit-function-declaration]
  return iptunnel_handle_offloads(skb, csum,
  ^
include/net/gre.h:42:2: warning: return makes pointer from integer
without a cast [enabled by default]
drivers/net/ipvlan/ipvlan_core.c: In function ‘ipvlan_process_v6_outbound’:
drivers/net/ipvlan/ipvlan_core.c:379:2: error: implicit declaration of function
‘ip6_route_output’ [-Werror=implicit-function-declaration]
  dst = ip6_route_output(dev_net(dev), NULL, &fl6);
  ^
drivers/net/ipvlan/ipvlan_core.c:379:6: warning: assignment makes
pointer from integer without a cast [enabled by default]
  dst = ip6_route_output(dev_net(dev), NULL, &fl6);
      ^
  CC [M]  drivers/mtd/mtdblock_ro.o
cc1: some warnings being treated as errors
make[3]: *** [drivers/net/ipvlan/ipvlan_core.o] Error 1
====================

You probably need to add a bunch of missing dependencies to
the Kconfig entry for the ipvlan driver.

For one thing it definitely needs "INET" and that explains
the lack of iptunnel_handle_offloads() when including net/gre.h

Likewise for the ipv6 stuff.