netdev - Re: [PATCH] skge: Unmask interrupts in case of spurious interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 1 Dec 2014 10:53:31 +0100
From:	Mirko Lindner <mlindner@...vell.com>
To:	Lino Sanfilippo <LinoSanfilippo@....de>
CC:	<stephen@...workplumber.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] skge: Unmask interrupts in case of spurious interrupts

On 30/11/14 12:51, Lino Sanfilippo wrote:
> In case of a spurious interrupt dont forget to reenable the interrupts that
> have been masked by reading the interrupt source register.
> 
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@....de>
> ---
>  drivers/net/ethernet/marvell/skge.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c
> index 264eab7..7173836 100644
> --- a/drivers/net/ethernet/marvell/skge.c
> +++ b/drivers/net/ethernet/marvell/skge.c
> @@ -3433,10 +3433,9 @@ static irqreturn_t skge_intr(int irq, void *dev_id)
>  
>  	if (status & IS_HW_ERR)
>  		skge_error_irq(hw);
> -
> +out:
>  	skge_write32(hw, B0_IMSK, hw->intr_mask);
>  	skge_read32(hw, B0_IMSK);
> -out:
>  	spin_unlock(&hw->hw_lock);
>  
>  	return IRQ_RETVAL(handled);
> 

Looks OK.

Acked-by: Mirko Lindner <mlindner@...vell.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html